Check if lockfile is valid before composing bundle #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
added
server
Graphite App
This stack of pull requests is managed by Graphite. Learn more about stacking. |
andyw8
approved these changes
Jan 21, 2025
vinistock
changed the base branch from
01-14-check_if_bundle_is_valid_before_restarting
to
graphite-base/3077
vinistock
force-pushed
the
01-17-check_if_lockfile_is_valid_before_composing_bundle
branch
from
98a89e8 to
e901279
Compare
vinistock
deleted the
01-17-check_if_lockfile_is_valid_before_composing_bundle
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After #3066 moves forward, we can start getting smarter about our checks of when it's valid to restart. For example, we don't need to go all the way to composing the bundle, if we already know the lockfile's syntax is invalid.
Implementation
Started parsing the lockfile before composing the bundle, so that we can more quickly reject a restart request if there's an issue.
Automated Tests
Added a test.