Use local executables when working on the Ruby LSP #3065
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was trying to make some more improvements to our launcher and I realized we were missing something we should have probably done about 2 years ago.
When working on the LSP itself, we don't use the local version of the launcher. We use the local version of the server, but only after the bundle has been composed. Composing the bundle uses whatever latest version is globally installed.
This is detrimental to us catching bugs in the launch process before releasing it to users. We need to change that.
Implementation
To ensure that the local version of the executable is always chosen when working on the LSP, I started mutating the
PATH
to include theexe
directory.That way, whenever
ruby-lsp
is invoked, the first thing that will be found is the local executable.Automated Tests
Added a test to make sure the
PATH
is being mutated.