Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use URI object when invoking vscode.open #2318

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Use URI object when invoking vscode.open #2318

merged 1 commit into from
Jul 17, 2024

Conversation

vinistock
Copy link
Member

Motivation

While adding jump to view on the Rails addon Shopify/ruby-lsp-rails#412, I noticed a few issues with the openUris implementation.

Implementation

  1. The vscode.open command expects a URI object, not a string
  2. We didn't have a title for the quick pick so the list of files just showed up with no explanation
  3. I added go to file icons to further communicate that selecting an option will jump to it
  4. The full URI is way too long to display as label. Started using only the file name

@vinistock vinistock added bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes labels Jul 17, 2024
@vinistock vinistock self-assigned this Jul 17, 2024
@vinistock vinistock requested a review from a team as a code owner July 17, 2024 14:04
@vinistock vinistock requested review from andyw8 and st0012 July 17, 2024 14:04
@vinistock vinistock merged commit 085e677 into main Jul 17, 2024
35 checks passed
@vinistock vinistock deleted the vs/open_uri_fixes branch July 17, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR will fix an existing bug vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants