Add jump to view code lenses #412
Conversation
vinistock
force-pushed
the
vs/add_jump_to_view_lenses
branch
from
1a7e37d to
5356284
Compare
| def add_jump_to_view(node) | ||
| class_name, _ = T.must(@constant_name_stack.last) | ||
| action_name = node.name | ||
| controller_name = class_name.delete_suffix("Controller").gsub(/([a-z])([A-Z])/, "\\1_\\2").downcase |
There was a problem hiding this comment.
I don't understand the intention behind the gsub here, can you explain?
There was a problem hiding this comment.
Ahhh, now I see, it's to find the individual words, since that's where there's a change in case.
There was a problem hiding this comment.
(is this copied straight from Rails?)
There was a problem hiding this comment.
No, I wrote it myself. It's turning the controller name into the directory path.
| action_name = node.name | ||
| controller_name = class_name.delete_suffix("Controller").gsub(/([a-z])([A-Z])/, "\\1_\\2").downcase | ||
|
|
||
| view_uris = Dir.glob("#{@client.rails_root}/app/views/#{controller_name}/#{action_name}*").map! do |path| |
There was a problem hiding this comment.
We could get this programatically:
irb(main):004> UsersController.view_paths.map(&:path)
=> ["/Users/andyw8/src/github.com/Shopify/ruby-lsp-rails/test/dummy/app/views"]
There was a problem hiding this comment.
(would require a little more plumbing for the server request of course)
There was a problem hiding this comment.
It doesn't look like that method is returning what we want though. It's returning the views directory, but not the directory for the UsersController views. Is there a way to make it return it?
There was a problem hiding this comment.
I tried but couldn't find an obvious way.
vinistock
force-pushed
the
vs/add_jump_to_view_lenses
branch
from
5356284 to
3256ff4
Compare
Closes #384
This PR adds the ability to jump to related views from a controller action.
Implementation:
ruby-lspjust to get proper ERB supportRails.rootfrom the server initialization response. We often need to know where the application exists from the addon sideScreen.Recording.2024-07-17.at.9.57.46.AM.mov