Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuring Mise executable path #1914

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

vinistock
Copy link
Member

Motivation

Closes #1822

Allow configuring the Mise executable path if it's not installed in the default location.

Implementation

Added a new setting under version manager. If the value is set to something, we use that as the Mise path, otherwise we fallback to the default installation path.

Automated Tests

Added a test to verify that we use the configured value to invoke Mise.

@vinistock vinistock added enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes labels Apr 11, 2024
@vinistock vinistock self-assigned this Apr 11, 2024
@vinistock vinistock requested a review from a team as a code owner April 11, 2024 13:43
@vinistock vinistock requested review from egiurleo and KaanOzkan April 11, 2024 13:43
Copy link
Contributor

@egiurleo egiurleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@vinistock vinistock merged commit 7bb5c85 into main Apr 11, 2024
41 checks passed
@vinistock vinistock deleted the vs/allow_configuring_mise_path branch April 11, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vscode This pull request should be included in the VS Code extension's release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support custom mise installation paths.
2 participants