Add support for ASDF_DIR environment variable #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
srcid
changed the title
vinistock
requested changes
Oct 9, 2024
There was a problem hiding this comment.
Thank you for the PR. I understand the use case, but reading that variable from the process env is not going to work for every case.
If someone opens VS Code from the terminal with code ., it will work because the editor will inherit the environment variables. But if someone opens from the app icon, then it will not inherit anything and the code will simply not work.
If ASDF can be installed in any arbitrary directory, then we should add a new setting for ASDF allowing people to configure where we look for it.
srcid
force-pushed
the
follow-asdf-dir-env-var
branch
from
0dd6719 to
80808c7
Compare
vinistock
reviewed
Oct 16, 2024
vinistock
added
enhancement
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
Co-authored-by: Vinicius Stock <vinistock@users.noreply.github.com>
srcid
force-pushed
the
follow-asdf-dir-env-var
branch
from
cb403eb to
ab5f2a6
Compare
vinistock
approved these changes
Oct 18, 2024
|
@vinistock I thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To handle custom asdf vm installation paths.
Closes #2686
ASDF supports custom installation paths using the asdf_dir env var, and ruby-lsp should look for it as it already supports ASDF. Currently, it tries the default installation paths only.
Implementation
I check if the ASDF_DIR env var do exists, and if it did, I try to find if the asdf script. Otherwise, it will follow the actual behavior.
Automated Tests
Since I only check if an env var exists, and didn't change the actual workflow of the extension, the current test suit should cover it up.
Manual Tests