Add watched_files_dynamic_registration to global state
#1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaanOzkan
approved these changes
Apr 10, 2024
KaanOzkan
added
enhancement
vinistock
approved these changes
Apr 10, 2024
This allows addons to check if they can register custom file change listerens. Work towards Shopify#326 It makes sense to add docs on how to make use of this option, but I'll defer that until after I've actually written some functioning code with it.
Earlopain
force-pushed
the
global-state-dynamic-watchers
branch
from
4347f63 to
430bb6c
Compare
|
Thank you for the contribution! |
|
Thanks for the merge. What would be the steps to make use of this in |
|
A We can bump the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Work towards Shopify/ruby-lsp-rails#326.
ruby-lsp-railswants to watch for file changes to**/structure.sql. This allows it to check if the client supports this functionality before trying to send the request.It makes sense to add docs on how/why you might make use of this option in an addon, but I'll defer that until after I've actually written some functioning code.
Implementation
Move the options extraction for this into the global state.
Automated Tests
Add a few variants that a client might send.
Manual Tests
Edit a ruby file and observe that the file watcher is still being registered, i.e. that the index is being updated.