Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document highlight breaking #326

Closed
vinistock opened this issue Oct 17, 2022 · 0 comments · Fixed by #343
Closed

Document highlight breaking #326

vinistock opened this issue Oct 17, 2022 · 0 comments · Fixed by #343
Assignees
@st0012
Labels
bug Something isn't working

Comments

@vinistock
Copy link
Member

vinistock commented Oct 17, 2022 •
edited by Morriar
Loading

Document highlight is currently breaking with undefined method 'child_nodes' for nil:NilClass at this part of code. It seems that, parent might be nil and the code is not prepared for it.
@vinistock vinistock added the bug Something isn't working label Oct 17, 2022
@st0012 st0012 self-assigned this Oct 24, 2022
@st0012 st0012 mentioned this issue Oct 25, 2022
Merged
vinistock pushed a commit that referenced this issue Feb 28, 2024
@github-actions
Merge pull request #326 from Shopify/dependabot/npm_and_yarn/vsce-2.15.0
2f94fc8 
Bump vsce from 2.14.0 to 2.15.0
Earlopain added a commit to Earlopain/ruby-lsp that referenced this issue Apr 9, 2024
@Earlopain
Add watched_files_dynamic_registration to global state
4347f63 
This allows addons to check if they can register custom file change listerens. Work towards Shopify#326

It makes sense to add docs on how to make use of this option,
but I'll defer that until after I've actually written some functioning code with it.
Earlopain added a commit to Earlopain/ruby-lsp that referenced this issue Apr 10, 2024
@Earlopain
Add watched_files_dynamic_registration to global state
430bb6c 
This allows addons to check if they can register custom file change listerens. Work towards Shopify#326

It makes sense to add docs on how to make use of this option,
but I'll defer that until after I've actually written some functioning code with it.
vinistock pushed a commit that referenced this issue Apr 10, 2024
@Earlopain
Add watched_files_dynamic_registration to global state (#1905)
f98f84f 
This allows addons to check if they can register custom file change listerens. Work towards #326

It makes sense to add docs on how to make use of this option,
but I'll defer that until after I've actually written some functioning code with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@st0012 st0012

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip node locating when the document is not parsed Shopify/ruby-lsp
3 participants
@st0012 @vinistock @adisonlampert