Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --customer-account-push flag when no domain is set in .env #2007

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Fix --customer-account-push flag when no domain is set in .env #2007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/cli/src/lib/dev-shared.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ import {getGraphiQLUrl} from './graphiql-url.js';

export function isMockShop(envVariables: Record<string, string>) {
return (
// We fallback to mock.shop if the env var is not set
!envVariables.PUBLIC_STORE_DOMAIN ||
envVariables.PUBLIC_STORE_DOMAIN === 'mock.shop'
envVariables.PUBLIC_STORE_DOMAIN === 'mock.shop' ||
// We fallback to mock.shop if the env var is falsy.
// When it's undefined, it might be overwritten by remote variables.
envVariables.PUBLIC_STORE_DOMAIN === ''
);
}

Expand Down
Loading