Fix --customer-account-push flag when no domain is set in .env #2007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1992
A bit of a tricky issue:
--customer-account-push__unstable
and have noPUBLIC_STORE_DOMAIN
in.env
, it will think you're using mock.shop and skip the tunnel. This would be correct if we had all the variables at this point, but this is only considering local variables. The domain might be injected later from remote/admin variables.PUBLIC_STORE_DOMAIN=""
in.env
overwrites remote values and uses mock.shop. We still need to disable tunnel in this case.To 🎩 , ensure
--customer-account-push__unstable
has the expected behavior when:PUBLIC_STORE_DOMAIN
is set to a real domain (e.g.hydrogen-preview.myshopify.com
) in.env
=> starts the tunnel + no warning.PUBLIC_STORE_DOMAIN
is undefined in.env
=> starts the tunnel + no warning.PUBLIC_STORE_DOMAIN
is set tomock.shop
in.env
=> skips the tunnel + info banner in terminal about mock.shop.PUBLIC_STORE_DOMAIN
is empty string in.env
=> skips the tunnel + info banner in terminal about mock.shop.