Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Product media zoom option #1381

Closed
wants to merge 4 commits into from
Closed

Product media zoom option #1381

wants to merge 4 commits into from

Conversation

tomoyanakano
Copy link

@tomoyanakano tomoyanakano commented Feb 20, 2022

Why are these changes introduced?

Fixes #733

What approach did you take?

  • add zoom options(enable or disable)to main product
  • add zoom options(enable or disable)to featured product
  • edit product thumbnail
    • add media zoom argument
    • if media zoom == 'disable' show product__media without modal-opener

I have to improve code more in product thumbnail(line: 114)

    <div style="width: 100%;"> 
      <div class="product__media media media--transparent gradient global-media-settings" style="padding-top: {{ 1 | divided_by: media.preview_image.aspect_ratio | times: 100 }}%;">

I think it would be class.
how should I name the element that has widht: 100% style?

Other considerations

I think it would be able to disable zoom by remove or invalidate javascript

Testing steps/scenarios

  • able to disable zoom on main product (desktop and mobile)
  • able to disable zoom on featured product (desktop and mobile)

Demo links
Please include a link to a demo store that includes preconfigured sections and settings to allow reviewers to easily test the features you are working on.

Checklist

@ghost ghost added the cla-needed label Feb 20, 2022
@tomoyanakano tomoyanakano changed the title Product zoom image option Product media zoom option Feb 20, 2022
@tomoyanakano tomoyanakano closed this by deleting the head repository Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable zoom on product pages
2 participants