Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Remove data/label meta fields from twitter cards #441

Merged
merged 2 commits into from
Jun 25, 2015
Merged

Remove data/label meta fields from twitter cards #441

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bba82ce
Remove data/label meta fields from twitter cards
cshold Jun 24, 2015
c47108b
Remove stray endif
cshold Jun 24, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions snippets/social-meta-tags.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,6 @@
<meta name="twitter:image" content="https:{{ product.featured_image.src | img_url: 'medium' }}">
<meta name="twitter:image:width" content="240">
<meta name="twitter:image:height" content="240">
<meta name="twitter:label1" content="Price">
{% assign price = product.price | money_with_currency | strip_html | escape %}
<meta name="twitter:data1" content="{% if product.price_varies %}{{ 'products.general.from_text_html' | t: price: price }}{% else %}{{ price }}{% endif %}">
{% if product.vendor != blank %}
<meta name="twitter:label2" content="Brand">
<meta name="twitter:data2" content="{{ product.vendor | escape }}">
{% else %}
<meta name="twitter:label2" content="Availability">
<meta name="twitter:data2" content="In stock">
{% endif %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this endif be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, thanks for catching

{% elsif template contains 'article' %}
<meta name="twitter:title" content="{{ article.title }}">
Expand Down