Skip to content
This repository has been archived by the owner on Aug 30, 2018. It is now read-only.

Remove data/label meta fields from twitter cards #441

Merged
merged 2 commits into from
Jun 25, 2015
Merged

Conversation

cshold
Copy link
Contributor

@cshold cshold commented Jun 24, 2015

Follow up to #436, label and data meta tags will be ignored when Twitter product cards are deprecated on July 3rd.

cc @carolineschnapp

<meta name="twitter:data2" content="{{ product.vendor | escape }}">
{% else %}
<meta name="twitter:label2" content="Availability">
<meta name="twitter:data2" content="In stock">
{% endif %}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this endif be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, thanks for catching

cshold added a commit that referenced this pull request Jun 25, 2015
Remove data/label meta fields from twitter cards
@cshold cshold merged commit d9a5087 into master Jun 25, 2015
@cshold cshold deleted the twitter-card-update branch June 25, 2015 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants