Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change default icon atlas size to 64x64 as this seens to be the new Factorio default #34

Closed
ShadowTheAge opened this issue May 27, 2020 · 1 comment
Closed

Change default icon atlas size to 64x64 as this seens to be the new Factorio default #34

ShadowTheAge opened this issue May 27, 2020 · 1 comment
Labels
Future feature

Comments

@ShadowTheAge
Copy link
Owner

This requires resizing internal UI icons
@ShadowTheAge
Copy link
Owner Author

ShadowTheAge commented May 27, 2020 •
edited
Loading

Tried it, looks less than ideal on low dpi screens (SDL probably doesn't have mip maps). Postpoining it for now.

craig-johnston pushed a commit to craig-johnston/yafc that referenced this issue Feb 28, 2024
@shpaass
Keep original lastRect to fix some drawing glitches (e.g. in ErrorRow) (
856c455 
ShadowTheAge#34)

ShadowTheAge#31 was missing an additional fix for the scroll area and their
scrollbars.
With this I did not see any glitches anymore, and the ScrollArea size is
set correctly now (showing scrollbars if needed).(hard to see/test, as
it was visible for the Summary tab which will be my next PR)

Adding a lastContentRect which contains the (correct/out-of-window)
size, fixes the contentSize calculation in BuildGui().
DaleStan referenced this issue in DaleStan/yafc May 9, 2024
@shpaass
Add a tab showing the production summary (shpaass#38)
afcb955 
I tried to reuse the existing UI of YAFC, so I based the whole thing on
a `ProjectPageContents` and a `ProjectPageView`, so it would be
recognized and fit into the `MainScreen` (tabs) and serialization.

The UI of the new 'Summary' tab is ugly, I tried making it nicer, but I
found it hard to understand the `ImGui` and its features and how to use
them... So I propose this could be further improved om in separate PRs
to get the basic functionality/feature into YAFC already and make it
available for everyone (I used it a lot and cannot live without this
anymore).

I also fixed some issues I found while implementing the Summary tab,
moved to shpaass#31 and shpaass#34, except for:
* calculating `DatGrid` width when header is not used (I found the
header useless here)

The original idea is from
ShadowTheAge#123
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Future feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ShadowTheAge