Optimization: don't duplicate logs #259
Assignees
Comments
aleksandr-kotlyar
added a commit
to aleksandr-kotlyar/webdriver_manager
that referenced
this issue
Oct 23, 2021
SergeyPirogov
pushed a commit
that referenced
this issue
Oct 24, 2021
* Optimization: define env var GH_TOKEN for all jobs * install stable chromium on mac * Tests: adopt edge tests for CI. * [#254] softly download latest webdriver version... even if browser version is UNKNOWN. * CI: add tests on windows github actions * [#259] fix duplicating logs when "latest" version's found * up version to 3.5.2 and update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Logs are duplicating for google-chrome, chromium and firefox
Why
Because
driver.get_version()calls multiply times and it callsget_latest_release_version()twice when version is "latest".Proposal solution
When webdriver-manager getting the latest release version - it should become a driver.version in case to not call
get_latest_release_version()twice when callingdriver.get_version()by second time.P.S. it will also speed up the webdriver-manager by reducing multiply requests to latest releases to only one request.
The text was updated successfully, but these errors were encountered: