-
-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimization: Don't check browser version when driver version was passed to webdriver-manager #254
Comments
aleksandr-kotlyar
added a commit
to aleksandr-kotlyar/webdriver_manager
that referenced
this issue
Oct 23, 2021
even if browser version is UNKNOWN.
aleksandr-kotlyar
added a commit
to aleksandr-kotlyar/webdriver_manager
that referenced
this issue
Oct 23, 2021
even if browser version is UNKNOWN.
aleksandr-kotlyar
added a commit
to aleksandr-kotlyar/webdriver_manager
that referenced
this issue
Oct 23, 2021
even if browser version is UNKNOWN.
SergeyPirogov
pushed a commit
that referenced
this issue
Oct 24, 2021
* Optimization: define env var GH_TOKEN for all jobs * install stable chromium on mac * Tests: adopt edge tests for CI. * [#254] softly download latest webdriver version... even if browser version is UNKNOWN. * CI: add tests on windows github actions * [#259] fix duplicating logs when "latest" version's found * up version to 3.5.2 and update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What
webdriver-manager could never cover all cases of getting installed browser version.
Why
because there are a lot of possibilities to install them on different machines.
Solution
Don't check browser version if driver version was passed manually to webdriver-manager.
Details
Solution details how it should be
webdriver version set manually
If you have set driver version for any manager and browser:
then webdriver-manager doesn't check anything and just downloads the version of webdriver you provided to manager.
webdriver version not set - "latest" used
If version hasn't been set for
then webdriver-manager checks browser's version of GoogleChrome, Chromium, MSEdge and downloads latest webdriver for this version.
If browser version is still UNKNOWN:
If version hasn't been set for
then webdriver-manager doesn't check browser's version of IE, Firefox, Opera and download the most latest webdriver.
P.S. Downloading version="latest" can still not match the installed browser version, then better to pass the right webdriver version to the webdriver-manager that matches the installed browser version.
The text was updated successfully, but these errors were encountered: