Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization: Don't check browser version when driver version was passed to webdriver-manager #254

Closed
aleksandr-kotlyar opened this issue Oct 20, 2021 · 1 comment · Fixed by #260
Assignees

Comments

@aleksandr-kotlyar
Copy link
Collaborator

aleksandr-kotlyar commented Oct 20, 2021

What

webdriver-manager could never cover all cases of getting installed browser version.

Why

because there are a lot of possibilities to install them on different machines.

Solution

Don't check browser version if driver version was passed manually to webdriver-manager.

Details

Solution details how it should be

webdriver version set manually

If you have set driver version for any manager and browser:

from webdriver_manager.chrome import ChromeDriverManager

ChromeDriverManager(version='83.0.4103').install()

then webdriver-manager doesn't check anything and just downloads the version of webdriver you provided to manager.

webdriver version not set - "latest" used

If version hasn't been set for

  • ChromeDriverManager
  • EdgeChromiumDriverManager

then webdriver-manager checks browser's version of GoogleChrome, Chromium, MSEdge and downloads latest webdriver for this version.

If browser version is still UNKNOWN:

  • Download latest release version of webdriver.

If version hasn't been set for

  • IEDriverManager
  • GeckoDriverManager
  • OperaDriverManager

then webdriver-manager doesn't check browser's version of IE, Firefox, Opera and download the most latest webdriver.

P.S. Downloading version="latest" can still not match the installed browser version, then better to pass the right webdriver version to the webdriver-manager that matches the installed browser version.

@aleksandr-kotlyar
Copy link
Collaborator Author

Aslo it will fix #251, and partially help with #193 and #205 issues when browser is installed somewhere on agents.

aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 23, 2021
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 23, 2021
aleksandr-kotlyar added a commit to aleksandr-kotlyar/webdriver_manager that referenced this issue Oct 23, 2021
@aleksandr-kotlyar aleksandr-kotlyar changed the title Don't check browser version when driver version was passed to webdriver-manager Optimization: Don't check browser version when driver version was passed to webdriver-manager Oct 23, 2021
SergeyPirogov pushed a commit that referenced this issue Oct 24, 2021
* Optimization: define env var GH_TOKEN for all jobs

* install stable chromium on mac

* Tests: adopt edge tests for CI.

* [#254] softly download latest webdriver version...

even if browser version is UNKNOWN.

* CI: add tests on windows github actions

* [#259] fix duplicating logs when "latest" version's found

* up version to 3.5.2 and update changelog
@aleksandr-kotlyar aleksandr-kotlyar self-assigned this May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant