Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/set saved loading issue #199

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Conversation

joshua-dean
Copy link
Collaborator

Fix set_saved issue with legacy submit button format

Description

SubmitButtons toolbox item can accept just a function instead of submit button items. The check for this happened after the #196 fix, which subsequently broke everything in these cases. Re-arranging the checks fixes this.

This one is on me for not properly testing all of the demos with features like this. I've tested all the demos with this fix and they are back to functional again.

Other additions

Added a build-dev-and-demo script to get better stack traces when I obliterate main like this

PR Checklist

  • Merged latest main
  • Version number in package.json has been bumped since last release
  • Version numbers match between package package.json and src/version.js
  • Ran npm install and npm run build AFTER bumping the version number
  • Updated documentation if necessary (currently just in api_spec.md)
  • Added changes to changelog.md

Breaking API Changes

nope

@joshua-dean joshua-dean added the bug Something isn't working label Oct 7, 2024
@joshua-dean joshua-dean self-assigned this Oct 7, 2024
Copy link
Member

@TrevorBurgoyne TrevorBurgoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 👍

@joshua-dean joshua-dean merged commit 7daaf91 into main Oct 7, 2024
@joshua-dean joshua-dean deleted the fix/set-saved-loading-issue branch October 7, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants