Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplification of
set_saved
for submit buttonsDescription
Closes #119. Between this and event listeners being in the
.ulabel
group, implementers of the tool should have full control over the reload prompt.I left
set_saved
as optional in the type, as theSubmitButtons
toolbox item will set the default regardless.tl;dr is
set_saved
on submit buttons now defaults to "false". If set to "true", it will callULabel.set_saved
, skipping the reload/nav prompt.PR Checklist
package.json
has been bumped since last releasepackage.json
andsrc/version.js
npm install
andnpm run build
AFTER bumping the version numberapi_spec.md
)changelog.md
Breaking API Changes
Technically the ability to make a submit button invalidate existing changes and force the reload prompt is gone.
If anyone was leveraging this functionality, let me know and I'll personally implement a feature to invalidate the save state on submit.