-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #451 testing certs for windows #596
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the build logs for Windows, and I see this:
mkdir: cannot create directory 'certs': File exists
I didn't see any output for the ./tools/generate-ssl-certs.sh
command, maybe that's OK?
Do we have any other way of knowing if this worked or not?
403457d
to
1500d87
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked at the build logs for Windows, and I see this:
mkdir: cannot create directory 'certs': File exists
I didn't see any output for the
./tools/generate-ssl-certs.sh
command, maybe that's OK?Do we have any other way of knowing if this worked or not?
It's hard because windows would open that in a separate window, that might not show in a Travis CI environment as it would be running in a subsystem of itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a CI and code point of view. Can we get a Windows dev to test this locally?
Also, @Grommers00, either in this PR or another issue you file, can we add docs on this bit? People on Windows can follow the same steps as you are doing in CI to get this to work locally.
Issue This PR Addresses
#451 fixed for windows certs.
Type of Change
Description
This installs openssl on our travis CI, and then runs a shell script that should generate the scripts needed to create our own certificates.
Checklist
Travis CI is run on the github repository, so it will be using the travis ci build here to do the testing.