Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #451 testing certs for windows #596

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

Grommers00
Copy link
Contributor

@Grommers00 Grommers00 commented Jan 24, 2020

Issue This PR Addresses

#451 fixed for windows certs.

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This installs openssl on our travis CI, and then runs a shell script that should generate the scripts needed to create our own certificates.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

Travis CI is run on the github repository, so it will be using the travis ci build here to do the testing.

@Grommers00 Grommers00 requested a review from humphd January 24, 2020 19:40
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the build logs for Windows, and I see this:

mkdir: cannot create directory 'certs': File exists

I didn't see any output for the ./tools/generate-ssl-certs.sh command, maybe that's OK?

Do we have any other way of knowing if this worked or not?

.travis.yml Show resolved Hide resolved
.travis.yml Show resolved Hide resolved
@Grommers00 Grommers00 force-pushed the fix451 branch 2 times, most recently from 403457d to 1500d87 Compare January 24, 2020 21:16
Copy link
Contributor Author

@Grommers00 Grommers00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the build logs for Windows, and I see this:

mkdir: cannot create directory 'certs': File exists

I didn't see any output for the ./tools/generate-ssl-certs.sh command, maybe that's OK?

Do we have any other way of knowing if this worked or not?

It's hard because windows would open that in a separate window, that might not show in a Travis CI environment as it would be running in a subsystem of itself.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a CI and code point of view. Can we get a Windows dev to test this locally?

Also, @Grommers00, either in this PR or another issue you file, can we add docs on this bit? People on Windows can follow the same steps as you are doing in CI to get this to work locally.

@Grommers00 Grommers00 added 0.5 area: CI/CD Continuous integration / Continuous delivery labels Jan 25, 2020
@lozinska lozinska self-requested a review January 27, 2020 15:05
@humphd humphd removed the 0.5 label Jan 27, 2020
@humphd humphd merged commit 2785b60 into Seneca-CDOT:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Continuous integration / Continuous delivery
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants