Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows script for generating SSL certs needed for SAML2 login flow #451

Closed
humphd opened this issue Dec 5, 2019 · 2 comments
Closed
Assignees
Labels
area: CI/CD Continuous integration / Continuous delivery area: sso Authentication

Comments

@humphd
Copy link
Contributor

humphd commented Dec 5, 2019

In #448 and #449 we're working on getting the SAML2 login flow working, and it will require SSL certs for development and testing. We have a script to do it on *nix, but not Windows.

There are a number of ways this can be done, see https://medium.com/the-new-control-plane/generating-self-signed-certificates-on-windows-7812a600c2d8. This fix needs to do at least 2 things:

  • add a script to tools/ that can be run in a Windows shell and will generate these certs
  • add a line to the Windows install portion of the .travis.yml file to run the script in CI
@manekenpix
Copy link
Member

@Grommers00 I found Microsoft documentation with multiples examples of how to create a certificate depending on your needs. I created a certificate using the first example, but since I'm not really sure what the certificate is for I couldn't test it with telescope. Let me know if it helps or if there's anything I could do to test it.

@manekenpix manekenpix added the area: sso Authentication label Jan 14, 2020
@Grommers00
Copy link
Contributor

Awesome! Thanks I'll take a look!

Grommers00 added a commit to Grommers00/telescope that referenced this issue Jan 24, 2020
Grommers00 added a commit to Grommers00/telescope that referenced this issue Jan 24, 2020
Grommers00 added a commit to Grommers00/telescope that referenced this issue Jan 24, 2020
Grommers00 added a commit to Grommers00/telescope that referenced this issue Jan 24, 2020
@humphd humphd closed this as completed in 2785b60 Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: CI/CD Continuous integration / Continuous delivery area: sso Authentication
Projects
None yet
Development

No branches or pull requests

3 participants