Fix post info to not overflow #2652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Ritik Bheda <ritik.bheda@gmail.com>
|
|
8 tasks
humphd
approved these changes
Jan 13, 2022
| @@ -29,14 +29,14 @@ type Props = { | |||
| const useStyles = makeStyles((theme: Theme) => | |||
| createStyles({ | |||
| root: { | |||
| display: 'flow-root', | |||
There was a problem hiding this comment.
Fascinating! I've never heard of it before, TIL. Nice work.
DukeManh
approved these changes
Jan 13, 2022
|
@Kevan-Y land this whenever you are ready. Nice work. |
|
I'm late to the party but I wanted to add that this is a VERY nice fix. Well done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue This PR Addresses
Fixes #2568
Type of Change
Description
The post info overflow the post container if the post text wasn't long enough.
I set the root to
display: flow-rootso it will makes sure everything will stay in that post container.Checklist