Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase minimum height to 400px #2626

Closed
wants to merge 1 commit into from

Conversation

ritikbheda
Copy link
Contributor

Issue This PR Addresses

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

Resolves #2568
The minimum height is now set to 400px and it resolves the minimum height problem.
look at the attached screenshot for more details.
minheight

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Dec 17, 2021

@AmasiaNalbandian
Copy link
Contributor

I think we need to explore this a little bit more. I just saw this post and realized the info section goes pretty long... this one is 772px! This goes to say the 400px won't cover this case.

image

I tried to look into setting a height based on the height of the GitHub Info but wasn't able to do anything with CSS, they are in different divs and components.

@Kevan-Y Kevan-Y self-requested a review January 13, 2022 02:42
@Kevan-Y
Copy link
Contributor

Kevan-Y commented Jan 13, 2022

Hi @ritikbheda, could you update this branch to the latest. Thanks

@humphd humphd removed the request for review from Kevan-Y January 13, 2022 14:07
@Kevan-Y
Copy link
Contributor

Kevan-Y commented Jan 13, 2022

Closing it, new PR open in #2652

@Kevan-Y Kevan-Y closed this Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Min-height for blog posts needs adjustment to avoid GitHub details overflowing into the next post
3 participants