Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace usage of valid-url package with URL parser #2349

Merged
merged 1 commit into from
Oct 11, 2021
Merged

Replace usage of valid-url package with URL parser #2349

merged 1 commit into from
Oct 11, 2021

Conversation

menghif
Copy link
Contributor

@menghif menghif commented Oct 10, 2021

Issue This PR Addresses

Fixes #2147

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR removes valid-url package and replaces it with URL parser.

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

humphd
humphd previously approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome

@manekenpix
Copy link
Member

@menghif can you rebase on master?

@manekenpix manekenpix added the dependencies Pull requests that update a dependency file label Oct 10, 2021
@humphd
Copy link
Contributor

humphd commented Oct 10, 2021

@menghif we're going to be covering rebasing/squashing this week, if you need help.

PedroFonsecaDEV
PedroFonsecaDEV previously approved these changes Oct 10, 2021
View reviewed changes
Copy link
Contributor

@PedroFonsecaDEV PedroFonsecaDEV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @menghif

@menghif menghif dismissed stale reviews from PedroFonsecaDEV and humphd via 6221b53 October 11, 2021 01:05
@menghif
Copy link
Contributor Author

menghif commented Oct 11, 2021

@humphd I watched this week's lecture on git rebase. It was very helpful, thank you!

@manekenpix manekenpix merged commit e1955f1 into Seneca-CDOT:master Oct 11, 2021
@menghif menghif deleted the issue-2147 branch October 17, 2021 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manekenpix manekenpix manekenpix approved these changes

@PedroFonsecaDEV PedroFonsecaDEV PedroFonsecaDEV approved these changes

@humphd humphd humphd left review comments

@cindyorangis cindyorangis Awaiting requested review from cindyorangis

Assignees

@menghif menghif

Labels
dependencies Pull requests that update a dependency file hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove valid-url package and usage throughout tree
4 participants
@menghif @manekenpix @humphd @PedroFonsecaDEV