Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove valid-url package and usage throughout tree #2147

Closed
humphd opened this issue Apr 14, 2021 · 2 comments · Fixed by #2349
Closed

Remove valid-url package and usage throughout tree #2147

humphd opened this issue Apr 14, 2021 · 2 comments · Fixed by #2349
Assignees
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Apr 14, 2021

We have a bunch of places in the project that use the https://www.npmjs.com/package/valid-url package. This code hasn't been updated in 8 years, and is totally unnecessary in modern browsers and node, which both ship a URL parser:

Let's drop this dependency and switch to using the maintained URL() function.

@humphd humphd added type: enhancement New feature or request dependencies Pull requests that update a dependency file labels Apr 14, 2021
@manekenpix manekenpix added the good first issue Good for newcomers label Oct 9, 2021
@menghif
Copy link
Contributor

menghif commented Oct 10, 2021

I would like to work on this :)

@manekenpix
Copy link
Member

@menghif All yours!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants