-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed#77: Added Dark theme #1637
Conversation
I am currently working on it. |
950659d
to
e96221c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works well, but there are some follow-up issues we need to do. At the very least, we need to better integrate this theme switching, and probably serialize the value to localStorage for the user with a hook.
Can you file an issue on this? Approved with that filed.
Issue This PR Addresses
Fixed #77
Type of Change
Description
I made some change to ensure we have the same UI as before with Gatsby and added the dark mode option. Since we have not had the header merged yet, I created a temporary toggle button to test the switch mode feature. The button can be found top right when you first load the page.
Light mode
Dark mode
Checklist