-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve dark mode code colours #2377
Comments
Hi @humphd, I would like to work on this. Please let me know if it is not assigned. |
@japneetsingh035 all yours! |
The red on black isn't great for contrast. I would look at the existing stylesheets that exist for dark-mode with highlight.js: |
Wow, someone is taking on this age-old issue? Originally #77 We had this working at some point on Telescope. It was added and removed by the Telescope 2.0 group. Maybe you can hunt down someone from that cohort who knows more... #1637 , as you can see, it was using the Material UI theming thing. We once had a button that we could toggle to switch to dark mode. |
Our dark mode isn't great for
<code>...</code>
(i.e., inline) and<pre><code>...</code></pre>
(i.e., block):We should probably take a look at how GitHub and other sites render code in dark mode, and see what we can borrow.
The text was updated successfully, but these errors were encountered: