-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate inactive blog url and include logic to filter inactive feeds #462
Comments
This changes quite a bit of stuff, will need discussion on how we should approach this. Should we create separate functions or use parameters for existing functions to determine what they should do with the feeds? |
@c3ho I think we should use a similar solution for this to what I'm suggesting in #624 (comment). Specifically, when a feed becomes "invalid" (maybe after we try it a bunch of times, it fails every time, and we give up on it), we set a key in Redis to indicate that. If the feed in question has an
NOTE: I'm using The value of the key can be some generated message that explains why the feed was made invalid, and when. Whenever we process a feed, we'd check on these so-called "feed status keys" to see if a feed is invalid:
If this gives back a value (1 for true), we know the invalid status is set for this feed, and can stop processing it. We can expose this on the let feed = await Feed.byId('ebbb25abaa');
let isInvalid = await feed.isInvalid();
// isInvalid is now true or false When we remove a feed from our system, we'll also need to remove the cc @Silvyre, who is working on similar code to this. |
Fixes #462, Integrate inactive blog url and include logic to filter inactive feeds
Currently we have work for the inactive blog, but we'll need smarter logic in order to filter feeds, could probably improve on this as we go.
The text was updated successfully, but these errors were encountered: