-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor inactive-blog-filter.js to use Redis vs. files #405
Comments
Please allow me! |
Stepping aside from this to assist with #406. Anyone is welcome to take my place. |
Karla and I are going to do this. |
Going to take #270 instead. Feel free to take this. |
If someone is not taking this, I think I can work on it too, since there is some dependency from #462 on this. |
This depends on changes from #462 |
@humphd Most of the code in in inactive-blog-filter is using a feedUrl, did you want to change to using a |
I want to get rid of this code completely, and use the the invalid key concept with a feed id like I mentioned in the other comments I left. |
Closing this as it was addressed by #630 |
We have some logic that is using files to deal with state, and we need to move that into Redis, so it can be distributed across nodes in production.
The various files that are being used in
inactive-blog-filter.js
should be refactored to use Sets in Redis, which we should be able to use to do set operations (unions, diffs, intersections, etc), and thereby keep our list of feeds up to date.See the code in
storage.js
for some ideas on how to do this. We'll need to add more code there for this use case.The text was updated successfully, but these errors were encountered: