Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Fix WSS scheme determination for DevTools connection #13131

Merged
merged 1 commit into from
Nov 10, 2023
Merged

[dotnet] Fix WSS scheme determination for DevTools connection #13131

merged 1 commit into from
Nov 10, 2023

Conversation

nvborisenko
Copy link
Member

Description

It was small bug in code how to determine web socket uri.

Motivation and Context

Fixes #12950

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

diemol
diemol approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @nvborisenko!

@diemol diemol merged commit 9fa9e96 into SeleniumHQ:trunk Nov 10, 2023
11 checks passed
@nvborisenko nvborisenko deleted the dotnet-devtools-wss branch November 10, 2023 10:30
@csgbn csgbn mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Dotnet devtools session does not support WSS?
2 participants
@nvborisenko @diemol