-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: WSS support (Ruby) #13167
Comments
@csgbn, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
We can confirm the C# WSS path is fixed in 4.16.0, thanks! |
Correction, fixed in 4.16.1. Also tested Ruby with 4.16.0, however has the exact same issue as in 4.15.0 as described in this ticket. |
@p0deje did we discuss this issue somewhere else, it sounds familiar? |
In Ruby we start secure socket connection as long as it's returned in connection URL - selenium/rb/lib/selenium/webdriver/common/websocket_connection.rb Lines 142 to 151 in a24a189
|
In the past I have relied on using |
I have landed the fix. Using |
Thanks @pujagani! I can now run Grid in SSL mode and I can see Ruby using
irb(main):003> options = Selenium::WebDriver::Options.chrome(web_socket_url: true)
=> #<Selenium::WebDriver::Chrome::Options:0x000000012fa44540
irb(main):005> driver = Selenium::WebDriver.for(:remote, :url => "https://192.168.1.34:4444", options: options)
=> #<Selenium::WebDriver::Remote::Driver:0x6270e210902b1bd2 browser=:chrome>
irb(main):010> driver.devtools
=>
#<Selenium::WebDriver::DevTools:0x000000010f9f8480
@session_id="9B7BC116F8AB06C39D3C80510149EC61",
@ws=
#<Selenium::WebDriver::WebSocketConnection:0x000000010f9f82a0
...
@url="wss://192.168.1.34:4444/session/3503fcf2569462fc1ecf3311c26580bf/se/cdp", # WSS URL
...
irb(main):006> driver.devtools.network.enable
=> {"id"=>3, "result"=>{}, "sessionId"=>"9B7BC116F8AB06C39D3C80510149EC61"}
irb(main):007> credentials = Base64.strict_encode64('admin:admin')
=> "YWRtaW46YWRtaW4="
irb(main):008> driver.devtools.network.set_extra_http_headers(headers: {authorization: "Basic #{credentials}"})
irb(main):009> driver.get('https://the-internet.herokuapp.com/basic_auth')
=> nil @csgbn Any idea what is different from your setup? |
closing as did not get a response. Adding links for asking questions below. |
💬 Please ask questions at:
|
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
This is a follow up on #12950
We are testing the language bindings against a distributed https grid with separate nodes from the hub in AWS. The grid supports both http and https.
One simple CDP smoke test is carried out with nodes started with --grid-url https://example.com (WSS) and another test with non secure web socket --grid-url http://example.com (WS)
Our grid and method is the same, we first verify that the CDP test works with WS then we test with WSS
Findings so far
Java - Works with both WS and WSS
C# - Works for WS but not for WSS and is being fixed #13131
Ruby - For Ruby we are seeing the same pattern as with C#, it works with WS but not WSS.
Before you asks for how are we deploying the grid and other specifics, please look into creating a test environment for testing a distributed https grid using WSS and CDP/BiDi and verify on your end, we could not find any reference that one exist and as for the case with C#, WSS path has never been tested...
We are supposed to test Python and Javascript CDP/BiDi next, please let us know if they do not yet have support for WSS CDP/BiDi, thanks.
How can we reproduce the issue?
Relevant log output
Operating System
Windows 11
Selenium version
4.15.0
What are the browser(s) and version(s) where you see this issue?
Chrome 119
What are the browser driver(s) and version(s) where you see this issue?
119.0.6045.105
Are you using Selenium Grid?
4.15.0
The text was updated successfully, but these errors were encountered: