Skip to content

Commit

Permalink
Update CRAN comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Selbosh committed Jul 19, 2021
1 parent 948c7c9 commit 9ae88dd
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 8 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# doseminer 0.1.2

* Remove the `output` column (only used for debugging) from the output of `extract_from_prescription`
* Remove the `output` column (only used for debugging) from the data frame returned by `extract_from_prescription`

# doseminer 0.1.1

Expand Down
12 changes: 5 additions & 7 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
## Test environments
* local R installation, R 4.0.5
* ubuntu 16.04 (on travis-ci), R 4.0.5
* local R installation, R 4.1.0
* ubuntu 16.04 (on travis-ci), R 4.1.0
* win-builder (devel)

## R CMD check results

0 errors | 0 warnings | 1 note
0 errors | 0 warnings | 0 notes

## Resubmission

* This is a resubmission (of a new release).
* Version 0.1.0 was accepted and sent to CRAN, but then failed on `r-oldrel`, due to `stringsAsFactors` causing some unit test comparisons to fail on older versions of R (i.e. < 4.0.0). This bug is now fixed.
* Minor update with tweaks to documentation and vignettes
* Only real change is omitting a debug column from the workhorse function

0 comments on commit 9ae88dd

Please sign in to comment.