Cogburn/pages #763
Merged
Cogburn/pages #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converted over the remaining routes. Some problems arose. Vue didn't like that some component tags were self-closing. In some places it messed up white space, in others controls weren't rendering at all. Occasionally, especially during Cypress tests, the page would load with a blank page in the v-app. Vue also didn't like `@update:modelUpdate` but worked when changed to `@update:model-update`. There might be a race condition between 1) The pages being loaded, 2) Vue, and 3) the Vue router.
…d waiting for all promises to finish. Made some adjustments to the jest tests to account for the adjusted Vue boot sequence. Reverted every self-closing tag that isn't <br/> to have an explicit closing tag. Refactored every Vue property binding and event binding to use kebab casing over camel case. Fixes for gridmember buttons. The binoculars are lowered and the light mode buttons are gray instead of white to provide contrast against the background.
jertel
approved these changes
Mar 4, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break out every page template into a new html file and load them on browser startup. Contains fixes for tests impacted by the updated Vue boot sequence.
Also contains fixes for buttons on the grid members page.