Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin matplotlib != 3.9.1 #6065

Merged
merged 3 commits into from
Jul 19, 2024
Merged

Pin matplotlib != 3.9.1 #6065

merged 3 commits into from
Jul 19, 2024

Conversation

pp-mo
Copy link
Member

@pp-mo pp-mo commented Jul 19, 2024

Should fix the plotting problems in #6029
See matplotlib/matplotlib#28567

@pp-mo pp-mo marked this pull request as ready for review July 19, 2024 14:14
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (c60afa8) to head (a4fe70a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6065   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          90       90           
  Lines       22996    22991    -5     
  Branches     5032     5030    -2     
=======================================
- Hits        20642    20638    -4     
  Misses       1623     1623           
+ Partials      731      730    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ESadek-MO ESadek-MO self-requested a review July 19, 2024 14:45
@ESadek-MO ESadek-MO self-assigned this Jul 19, 2024
Copy link
Contributor

@ESadek-MO ESadek-MO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pp-mo!

@ESadek-MO ESadek-MO enabled auto-merge (squash) July 19, 2024 14:46
@pp-mo pp-mo linked an issue Jul 19, 2024 that may be closed by this pull request
2 tasks
@ESadek-MO ESadek-MO merged commit ee6f186 into SciTools:main Jul 19, 2024
20 checks passed
@pp-mo
Copy link
Member Author

pp-mo commented Jul 19, 2024

Thanks to @rcomer -- your diagnosis enormously helpful !
💐

tkknight added a commit to tkknight/iris that referenced this pull request Jul 21, 2024
* upstream/main:
  Updated environment lockfiles (SciTools#6029)
  Pin matplotlib != 3.9.1 (SciTools#6065)
  add location argument to mesh.coords (SciTools#6055)
  Doctest compatibility with GeoVista v0.5. (SciTools#6064)
  Rename `Mesh` to `MeshXY` (SciTools#6056)
  Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emerging CI problem with lockfile update
2 participants