Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add location argument to mesh.coords #6055

Merged
merged 15 commits into from
Jul 19, 2024

Conversation

stephenworsley
Copy link
Contributor

🚀 Pull Request

Closes #5993

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.76%. Comparing base (c60afa8) to head (bbdb7e4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6055   +/-   ##
=======================================
  Coverage   89.76%   89.76%           
=======================================
  Files          90       90           
  Lines       22996    22991    -5     
  Branches     5032     5030    -2     
=======================================
- Hits        20642    20638    -4     
  Misses       1623     1623           
+ Partials      731      730    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stephenworsley stephenworsley marked this pull request as ready for review July 17, 2024 14:22
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some fairly wide scope things for you. I will hold off more detailed reviewing until we have some conclusions.

Thanks!

lib/iris/experimental/ugrid/mesh.py Outdated Show resolved Hide resolved
lib/iris/experimental/ugrid/mesh.py Outdated Show resolved Hide resolved
lib/iris/experimental/ugrid/mesh.py Outdated Show resolved Hide resolved
lib/iris/experimental/ugrid/mesh.py Outdated Show resolved Hide resolved
@pp-mo pp-mo mentioned this pull request Jul 18, 2024
9 tasks
Copy link
Contributor

@trexfeathers trexfeathers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful work @stephenworsley - neater, less confusing, and true to the original philosophy of identical signatures all eventually passing down to the filters() method.

benchmarks/benchmarks/unit_style/ugrid.py Outdated Show resolved Hide resolved
lib/iris/tests/unit/experimental/ugrid/mesh/test_Mesh.py Outdated Show resolved Hide resolved
lib/iris/experimental/ugrid/mesh.py Show resolved Hide resolved
* main:
  Rename `Mesh` to `MeshXY` (SciTools#6056)
  Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)

# Conflicts:
#	docs/src/whatsnew/latest.rst
@trexfeathers trexfeathers enabled auto-merge (squash) July 19, 2024 13:48
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good I think, just needs an approval.

@pp-mo pp-mo dismissed trexfeathers’s stale review July 19, 2024 14:41

All comments now resolved.

@trexfeathers trexfeathers merged commit 25b8752 into SciTools:main Jul 19, 2024
21 checks passed
tkknight added a commit to tkknight/iris that referenced this pull request Jul 21, 2024
* upstream/main:
  Updated environment lockfiles (SciTools#6029)
  Pin matplotlib != 3.9.1 (SciTools#6065)
  add location argument to mesh.coords (SciTools#6055)
  Doctest compatibility with GeoVista v0.5. (SciTools#6064)
  Rename `Mesh` to `MeshXY` (SciTools#6056)
  Bump scitools/workflows from 2024.07.2 to 2024.07.3 (SciTools#6063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better API for accessing coordinates on a Mesh
3 participants