MNT: Use pathlib for path conversions in setup.py #2026
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows building with newer setuptools (61.0.0+) which have removed convert_path, which we can just rely on pathlib for here.
stickler-ci
reviewed
Mar 25, 2022
| import os | ||
| from pathlib import Path |
There was a problem hiding this comment.
E402 module level import not at top of file
| import shutil | ||
| import subprocess | ||
| import warnings | ||
| from collections import defaultdict | ||
| from sysconfig import get_config_var | ||
|
|
||
| from setuptools import Command, Extension, convert_path, setup | ||
| from setuptools import Extension, setup |
There was a problem hiding this comment.
E402 module level import not at top of file
|
Oops, I did not see that there was already another PR opened to address this. Lets try to merge the other one over this if possible. |
|
@greglucas & @glentakahashii You both close your PRs... |
|
I just opened a new one with yet a different approach. #2027 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows building with newer setuptools (61.0.0+) which have
removed convert_path, which we can just rely on pathlib for here. Also removes some unused imports.
fixes #2021