-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bad import in setup.py #2025
Conversation
@@ -31,8 +31,9 @@ | |||
import warnings | |||
from collections import defaultdict | |||
from sysconfig import get_config_var | |||
from distutils.util import convert_path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E402 module level import not at top of file
setup.py
Outdated
|
||
from setuptools import Command, Extension, convert_path, setup | ||
from setuptools import Command, Extension, setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
F401 'setuptools.Command' imported but unused
E402 module level import not at top of file
from sysconfig import get_config_var | ||
|
||
from setuptools import Command, Extension, convert_path, setup | ||
from setuptools import Extension, setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E402 module level import not at top of file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure what to do here, want to keep it in the style of the original code, however the original code doesn't have a lint ignore comment. Should one be added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about it; setup.py
is excluded in setup.cfg
, but I guess stickler doesn't check that config file.
I actually don't see any point in using In fact, I don't see the point in either, since Windows understands |
@glentakahashi, sorry I opened another PR without realizing you'd already opened this (#2026). I don't think we want distutils here. I agree we can probably just remove the |
Ah @greglucas your version is better, so I'll close this one out and we should use yours |
@glentakahashi I just opened #2027 with yet another approach. Can you comment over there if that works for you too? |
Fixes #2021