Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deployment template schema for Edge Runtime 1.1 and 1.2 #1784

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

marianan
Copy link
Contributor

@marianan marianan commented Aug 6, 2021

This change adds deployment template manifest schema to support EdgeRuntime 1.1 and 1.2 updated schemas.
The schema resolves without issues locally but fails when added to tests in the repo - I am still investigating this but wanted to get started on the review of the changes in parallel.

@GerryFerdinandus
Copy link
Contributor

@marianan
You must also update the schema-validation.json if you $ref one schema to the other.
Look at the other example.

{
"azure-iot-edge-deployment-template-1.0.json": {
"externalSchema": [
"azure-iot-edge-deployment-1.0.json"
]
}
},
{
"azure-iot-edge-deployment-template-2.0.json": {
"unknownKeywords": [
"examples",
"contentMediaType"
],
"externalSchema": [
"azure-iot-edge-deployment-2.0.json"
]
}
},

@marianan
Copy link
Contributor Author

marianan commented Aug 6, 2021

thanks for the example. i updated the schema-validation.json


In reply to: 894432333

@GerryFerdinandus
Copy link
Contributor

@madskristensen Don't forget to merge this PR from last week

@madskristensen madskristensen merged commit 6fff4a1 into SchemaStore:master Aug 9, 2021
@madskristensen
Copy link
Contributor

Thanks

hayssams added a commit to ebiznext/schemastore that referenced this pull request Aug 25, 2021
* master: (59 commits)
  fix: missing run property introduced in v3.7.0 of taskfile (SchemaStore#1801)
  fix: [gitlab] allow_failure is missing "exit_codes" (SchemaStore#1798)
  Add Drone concurrency (SchemaStore#1796)
  Allow key: value requirements in Bamboo specs (SchemaStore#1795)
  Corrected values for modules-download-mode: (SchemaStore#1792)
  Update skaffold.yaml schema to v2beta21 (SchemaStore#1793)
  Add schema for Scoop manifests (SchemaStore#1790)
  Support month and day ranges in github-workflow (SchemaStore#1791)
  Update catalog.json (SchemaStore#1789)
  fix(ansible): allow all string inputs for "insertafter" and "insertbefore" on different modules (SchemaStore#1781)
  Add deployment template schema for Edge Runtime 1.1 and 1.2 (SchemaStore#1784)
  Add schema for Citation File Format (SchemaStore#1788)
  Add Knative Func Plugin func.yaml schema (SchemaStore#1787)
  Update tsconfig.json schema with new ts-node options from v10.1.0 and v10.2.0 (SchemaStore#1785)
  Updated skaffold to v2beta20 (SchemaStore#1780)
  Add JSON schema for .appsemblerc.yaml (SchemaStore#1779)
  Fix GitHub Workflow MacOS runners (SchemaStore#1777)
  Add schema for saucectl configuration files (SchemaStore#1775)
  fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name  (SchemaStore#1776)
  fix: point json resume to repository (SchemaStore#1773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants