Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name #1776

Merged
merged 10 commits into from
Aug 2, 2021

Conversation

GerryFerdinandus
Copy link
Contributor

@GerryFerdinandus GerryFerdinandus commented Jul 31, 2021

These issue tested with for Ansible 2.9 can be closed

close #1774
close #1439
close #1497 close #1159 (same issue module: package)
close #509 (was already fixed. Add test file for module: yum)
close #1256

Maintenance
close #1142 (Already using a better validator than tv4. And schema with issue's are place in separate list in src/schema-validation.json)
close #773 (This project run on non-microsoft platforms)

GerryFerdinandus and others added 10 commits July 31, 2021 10:22
This does not pass the build
Now also accept all string input
This does not pass the build
This is a copy from the example page.

Also add "name": "..." or else it will not pass the build.
This is an other issue that need to be fix
It is now integer and not string as the example

note that the example also accept type "null"
This does not pass the build
was only accepting string
It now accept both string + array
issue #509
Ansible schema doesn't handle lists passed to yum module

But it is all ready fix
see issue #1256
Ansible template type has an attribute validate which is set to boolean in the JSON schema,
but should be string.
issue #1256
Ansible template type has an attribute validate which is set to boolean
in the JSON schema, but should be string.
The copy one has the same validate type and should be checked
and also corrected while working on this.

But there is no "validate" proprety in the module.copy schema.
I do not know how this is posible. This schema ia auto gererated from the
documentation.

Add test module_copy.json to check if any this else is wrong.
The test module_copy.json does not detect this missing property
because there is no "additionalProperties": false for this "properties"
@madskristensen madskristensen merged commit a22542a into SchemaStore:master Aug 2, 2021
@madskristensen
Copy link
Contributor

thanks

@GerryFerdinandus GerryFerdinandus deleted the pr_ansible branch August 2, 2021 17:09
hayssams added a commit to ebiznext/schemastore that referenced this pull request Aug 25, 2021
* master: (59 commits)
  fix: missing run property introduced in v3.7.0 of taskfile (SchemaStore#1801)
  fix: [gitlab] allow_failure is missing "exit_codes" (SchemaStore#1798)
  Add Drone concurrency (SchemaStore#1796)
  Allow key: value requirements in Bamboo specs (SchemaStore#1795)
  Corrected values for modules-download-mode: (SchemaStore#1792)
  Update skaffold.yaml schema to v2beta21 (SchemaStore#1793)
  Add schema for Scoop manifests (SchemaStore#1790)
  Support month and day ranges in github-workflow (SchemaStore#1791)
  Update catalog.json (SchemaStore#1789)
  fix(ansible): allow all string inputs for "insertafter" and "insertbefore" on different modules (SchemaStore#1781)
  Add deployment template schema for Edge Runtime 1.1 and 1.2 (SchemaStore#1784)
  Add schema for Citation File Format (SchemaStore#1788)
  Add Knative Func Plugin func.yaml schema (SchemaStore#1787)
  Update tsconfig.json schema with new ts-node options from v10.1.0 and v10.2.0 (SchemaStore#1785)
  Updated skaffold to v2beta20 (SchemaStore#1780)
  Add JSON schema for .appsemblerc.yaml (SchemaStore#1779)
  Fix GitHub Workflow MacOS runners (SchemaStore#1777)
  Add schema for saucectl configuration files (SchemaStore#1775)
  fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name  (SchemaStore#1776)
  fix: point json resume to repository (SchemaStore#1773)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment