-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name #1776
Merged
madskristensen
merged 10 commits into
SchemaStore:master
from
GerryFerdinandus:pr_ansible
Aug 2, 2021
Merged
fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name #1776
madskristensen
merged 10 commits into
SchemaStore:master
from
GerryFerdinandus:pr_ansible
Aug 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not pass the build
Now also accept all string input
This does not pass the build This is a copy from the example page. Also add "name": "..." or else it will not pass the build. This is an other issue that need to be fix
It is now integer and not string as the example note that the example also accept type "null"
This does not pass the build
was only accepting string It now accept both string + array
issue #509 Ansible schema doesn't handle lists passed to yum module But it is all ready fix
see issue #1256 Ansible template type has an attribute validate which is set to boolean in the JSON schema, but should be string.
issue #1256 Ansible template type has an attribute validate which is set to boolean in the JSON schema, but should be string. The copy one has the same validate type and should be checked and also corrected while working on this. But there is no "validate" proprety in the module.copy schema. I do not know how this is posible. This schema ia auto gererated from the documentation. Add test module_copy.json to check if any this else is wrong. The test module_copy.json does not detect this missing property because there is no "additionalProperties": false for this "properties"
thanks |
hayssams
added a commit
to ebiznext/schemastore
that referenced
this pull request
Aug 25, 2021
* master: (59 commits) fix: missing run property introduced in v3.7.0 of taskfile (SchemaStore#1801) fix: [gitlab] allow_failure is missing "exit_codes" (SchemaStore#1798) Add Drone concurrency (SchemaStore#1796) Allow key: value requirements in Bamboo specs (SchemaStore#1795) Corrected values for modules-download-mode: (SchemaStore#1792) Update skaffold.yaml schema to v2beta21 (SchemaStore#1793) Add schema for Scoop manifests (SchemaStore#1790) Support month and day ranges in github-workflow (SchemaStore#1791) Update catalog.json (SchemaStore#1789) fix(ansible): allow all string inputs for "insertafter" and "insertbefore" on different modules (SchemaStore#1781) Add deployment template schema for Edge Runtime 1.1 and 1.2 (SchemaStore#1784) Add schema for Citation File Format (SchemaStore#1788) Add Knative Func Plugin func.yaml schema (SchemaStore#1787) Update tsconfig.json schema with new ts-node options from v10.1.0 and v10.2.0 (SchemaStore#1785) Updated skaffold to v2beta20 (SchemaStore#1780) Add JSON schema for .appsemblerc.yaml (SchemaStore#1779) Fix GitHub Workflow MacOS runners (SchemaStore#1777) Add schema for saucectl configuration files (SchemaStore#1775) fix: [ansible] lineinfile.insertafter, lineinfile.insertbefore, pause.minutes and package.name (SchemaStore#1776) fix: point json resume to repository (SchemaStore#1773) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These issue tested with for Ansible 2.9 can be closed
close #1774
close #1439
close #1497 close #1159 (same issue module: package)
close #509 (was already fixed. Add test file for module: yum)
close #1256
Maintenance
close #1142 (Already using a better validator than tv4. And schema with issue's are place in separate list in src/schema-validation.json)
close #773 (This project run on non-microsoft platforms)