Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShellCheck Warnings and Improve Build Scripts #964

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Fix ShellCheck Warnings and Improve Build Scripts #964

merged 2 commits into from
Jan 13, 2025

Conversation

BDadmehr0
Copy link
Member

Improved Security and File Compatibility:

  • Replaced *.o with ./*.o in scripts to prevent misinterpretation of file names starting with a -.

Enhanced Script Structure and Readability:

  • Added user-friendly error and warning messages.
  • Utilized optimized commands to prevent potential errors in different environments.

And more error :

  • SC2181
  • SC2086
  • SC2034

@BDadmehr0 BDadmehr0 mentioned this pull request Jan 13, 2025
Closed
@BaseMax BaseMax merged commit 29c2e8e into SalamLang:main Jan 13, 2025
12 of 14 checks passed
@BDadmehr0 BDadmehr0 deleted the bash-lint-fix branch January 13, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BaseMax BaseMax BaseMax approved these changes

@jbampton jbampton Awaiting requested review from jbampton jbampton is a code owner

Assignees
No one assigned
Labels
repo scripts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BDadmehr0 @BaseMax