Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash errors/warnings #957

Closed
BaseMax opened this issue Jan 13, 2025 · 1 comment
Closed

Bash errors/warnings #957

BaseMax opened this issue Jan 13, 2025 · 1 comment

Comments

@BaseMax
Copy link
Member

BaseMax commented Jan 13, 2025

source: https://github.com/SalamLang/Salam/actions/runs/12753297958/job/35544649360

image

2025-01-13 18:07:31 [INFO]   Linting BASH items...
  Error: -13 18:07:32 [ERROR]   Found errors when linting BASH. Exit code: 1.
  2025-01-13 18:07:32 [INFO]   Command output for BASH:
  ------
  
  In /github/workspace/build-linux.sh line 37:
  	if [ $? -ne 0 ]; then
               ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  
  
  In /github/workspace/build-linux.sh line 45:
  gcc -o "$output" *.o
                   ^-- SC2035 (info): Use ./*glob* or -- *glob* so names with dashes won't become options.
  
  
  In /github/workspace/build-linux.sh line 46:
  if [ $? -ne 0 ]; then
       ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  
  
  In /github/workspace/build-linux.sh line 57:
  if [ $? -ne 0 ]; then
       ^-- SC2[181](https://github.com/SalamLang/Salam/actions/runs/12753297958/job/35544649360#step:4:183) (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  
  
  In /github/workspace/build-webassembly.sh line 44:
  	DEBUG=1
          ^---^ SC2034 (warning): DEBUG appears unused. Verify use (or export if used externally).
  
  
  In /github/workspace/build-webassembly.sh line 54:
  	${MEMORY_FLAGS} \
          ^-------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  
  Did you mean: 
  	"${MEMORY_FLAGS}" \
  
  
  In /github/workspace/build-webassembly.sh line 55:
  	${RUNTIME_FLAGS} \
          ^--------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
@BDadmehr0
Copy link
Member

#964

@BaseMax BaseMax closed this as completed Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants