test: by default, don't generate code for runner integration #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are now split at the top level into whether code for the runner integration should be created or not.
It's now the default anyway.
…d of `output` This is where they are created by default. Originally, we needed two locations since files had to be written to disk instead of just being compared in memory.
This allows easy updates.
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 92 92
Lines 16804 16809 +5
Branches 3404 3406 +2
=========================================
+ Hits 16804 16809 +5 ☔ View full report in Codecov by Sentry. |
lars-reimann
deleted the
900-use-eject-as-baseline-in-generator-tests
branch
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #900
Summary of Changes
toMatchFileSnapshotto easily be able to update the expected output after changes to the code generator. Runvitest --updateto do so.