Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "eject" as baseline in generator tests #900

Closed
lars-reimann opened this issue Feb 20, 2024 · 1 comment · Fixed by #905
Closed

Use "eject" as baseline in generator tests #900

lars-reimann opened this issue Feb 20, 2024 · 1 comment · Fixed by #905
Assignees
Labels
released Included in a release testing 🧪 Additional automated tests
Milestone

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Feb 20, 2024

Currently, we include runner integration in the generator tests by default and have a few tests for the "eject" functionality. This means, changes to the runner integration code affects multiple (unrelated) test files.

It would be preferable, if we would use the "eject" functionality by default and then add a few tests targeting the generation of code for the runner integration.

@lars-reimann lars-reimann added the testing 🧪 Additional automated tests label Feb 20, 2024
@lars-reimann lars-reimann added this to the Future milestone Feb 20, 2024
@lars-reimann lars-reimann added this to DSL Feb 20, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL Feb 20, 2024
@lars-reimann lars-reimann moved this from Backlog to Todo in DSL Feb 21, 2024
@lars-reimann lars-reimann moved this from Todo to In Progress in DSL Feb 21, 2024
@lars-reimann lars-reimann modified the milestones: Future, v0.8.0 Feb 21, 2024
@lars-reimann lars-reimann self-assigned this Feb 21, 2024
lars-reimann added a commit that referenced this issue Feb 21, 2024
Closes #900

### Summary of Changes

* We now have only a few targeted generator tests for the runner
integration, instead of having this scattered across almost all tests.
* Use vitest's `toMatchFileSnapshot` to easily be able to update the
expected output after changes to the code generator. Run `vitest
--update` to do so.
@github-project-automation github-project-automation bot moved this from In Progress to ✔️ Done in DSL Feb 21, 2024
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release testing 🧪 Additional automated tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant