Kube Terminal: Appears to hang if it takes a while to start up #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expected url, got chart file name - We now check for this, if url is not absoulte assume filename and append to repo url
…wnload-url-for-filenames
…into fix-helm-hub-schema
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
=======================================
Coverage 57.83% 57.83%
=======================================
Files 1063 1063
Lines 34428 34428
Branches 4890 4890
=======================================
Hits 19910 19910
Misses 14518 14518 |
richard-cox
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically occurs on first load when the container image has to be fetched and thus it takes a while.
The back-end times out reading from the front-end - which obviously hasn't send any key strokes - but the terminal looks okay, but typing does not send anything to the terminal.
Fixes #505