Fix issue with Schemas on Helm Hub #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Expected url, got chart file name - We now check for this, if url is not absoulte assume filename and append to repo url
richard-cox
approved these changes
Sep 22, 2020
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 57.83% 57.83% -0.01%
==========================================
Files 1064 1063 -1
Lines 34393 34428 +35
Branches 4876 4890 +14
==========================================
+ Hits 19892 19910 +18
- Misses 14501 14518 +17 |
richard-cox
added a commit
that referenced
this pull request
Sep 22, 2020
* Fix issue where chart download link was not absolute - Expected url, got chart file name - We now check for this, if url is not absoulte assume filename and append to repo url * Fix issue with Schemas on Helm Hub * Update following changes in #503 * Fix issue with missing schema on upgrade for local chart * Fix failing unit test * Ensure kube terminal does not hang if it takes a while to start up * Fix timeout issue Co-authored-by: Richard Cox <richard.cox@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
Fixes #497. See also #502