feat(packages/sui-i18n): import node-polyglot 0.43 to our package #1528
Conversation
jordevo
requested review from
kikoruiz,
rmoralp,
sui-bot,
arnau-rius and
andresz1
as code owners
| // BSD 2-Clause License | ||
|
|
||
| // Copyright (c) 2012, Airbnb | ||
| // All rights reserved. |
There was a problem hiding this comment.
ℹ️ license notice kept here as per:
https://github.com/airbnb/polyglot.js/blob/master/LICENSE
- Redistributions of source code must retain the above copyright notice, this
list of conditions and the following disclaimer.
There was a problem hiding this comment.
👉 A -personal- suggestion regarding this:
Would it make sense to have a specific file to maintain all third-party license notices? Relating each notice to the specific dependency that requires it.
There was a problem hiding this comment.
good point! not sure what's the best way to deal with this in our packages.
There was a problem hiding this comment.
We could open an issue to discuss this point and avoid blocking this PR. What do you think?
There was a problem hiding this comment.
totally agree!
Just opened it: #1530
| // BSD 2-Clause License | ||
|
|
||
| // Copyright (c) 2012, Airbnb | ||
| // All rights reserved. |
There was a problem hiding this comment.
👉 A -personal- suggestion regarding this:
Would it make sense to have a specific file to maintain all third-party license notices? Relating each notice to the specific dependency that requires it.
| // BSD 2-Clause License | ||
|
|
||
| // Copyright (c) 2012, Airbnb | ||
| // All rights reserved. |
There was a problem hiding this comment.
We could open an issue to discuss this point and avoid blocking this PR. What do you think?
Description
Import
node-polyglot 0.43code to our package.Polyglot adapter is already being fully tested:
https://github.com/SUI-Components/sui/blob/master/packages/sui-i18n/test/polyglotSpec.js#L53
Related Issue
Implements #1468 .
Example