Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sui-i18n] Move external dependency to package #1468

Closed
rmoralp opened this issue Sep 29, 2022 · 0 comments
Closed

[sui-i18n] Move external dependency to package #1468

rmoralp opened this issue Sep 29, 2022 · 0 comments

Comments

@rmoralp
Copy link
Contributor

rmoralp commented Sep 29, 2022

Package

@s-ui/i18n

Description

This package has node-polyglot@0.4.3 as a dependency.
This version size is about 2.3kB minified

Given latest node-polyglot version (2.4.2) size is about 35.5kB minified
And current version achieve all our requirements
Then we have decided to move node-polyglot@0.4.3 code to @s-ui/i18n package and maintain this code.

Additional Information

This task is not only about moving code to our package, we want to keep our code style and also cover it with tests

@rmoralp rmoralp changed the title [sui-i18n] Move external dependency to sui-i18n package [sui-i18n] Move external dependency to package Sep 29, 2022
@jordevo jordevo self-assigned this Oct 13, 2022
@jordevo jordevo closed this as completed Dec 5, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Hacktoberfest 2022 🎉 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants