[INTERNAL] lib/processors/jsdoc: enhance list of built-in types and remove direct usage of taffydb #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emove direct usage of taffydb TODO: most parts of the hard coded lists should be replaced with content from the npm package 'globals'. Cherry picked from SAP/openui5@b53bbcc84. ---------------------------- Avoid the use of TaffyDB APIs in the active publishing variants (apijson, apixml, fullapixml) as not all TaffyDB APIs are supported by the replacement 'Salty' in JSDoc 4.0.0. The get() API is still used, all other operations are replaced with native array operations. Legacy publishing variants (apijs, full, public, demokit, demokit-internal) are not adapted as they are no longer functional. They'll be cleaned up in a later change. JIRA: CPOUI5FOUNDATION-595 Cherry picked from SAP/openui5@187bc3e07.
RandomByte
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
Personally, I'd prefer to have one commit per cherry-pick to make it easier to compare to the commits in OpenUI5. The title of commit [INTERNAL] JSDoc: prepare for the use of JSDoc 4.0.0 now doesn't appear anywhere here.
I think that's also what Frank usually does: #878
Besides that, looks good and contains all the missing change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: most parts of the hard coded lists should be replaced with content
from the npm package 'globals'.
Cherry picked from SAP/openui5@b53bbcc84.
Avoid the use of TaffyDB APIs in the active publishing variants
(apijson, apixml, fullapixml) as not all TaffyDB APIs are supported by
the replacement 'Salty' in JSDoc 4.0.0.
The get() API is still used, all other operations are replaced with
native array operations.
Legacy publishing variants (apijs, full, public, demokit,
demokit-internal) are not adapted as they are no longer functional.
They'll be cleaned up in a later change.
JIRA: CPOUI5FOUNDATION-595
Cherry picked from SAP/openui5@187bc3e07.