Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align jsdoc with openui5 #878

Merged
merged 3 commits into from
Jan 27, 2023
Merged

Align jsdoc with openui5 #878

merged 3 commits into from
Jan 27, 2023

Conversation

codeworrior
Copy link
Member

No description provided.

Used to list the optional @params of a method which can not only be
given as undefined, but also omitted (implementation supports shifting
of the subsequent parameters).

Cherry picked from SAP/openui5@d15835140.
Otherwise this function which returns either an object or null:
@returns {function(sap.ui.core.Control): ({rows: int, columns:
int}|null)|undefined}

ends up as:
function(sap.ui.core.Control):{rows: int, columns: int} | null |
undefined

Which means the function *always* has an object as result and there
could be null or undefined as *alternative* to the function.

Cherry picked from SAP/openui5@b21d5c95c.
@coveralls
Copy link

Coverage Status

Coverage: 94.609%. Remained the same when pulling aba8edc on align-jsdoc-with-openui5 into 9aa8b1c on main.

@codeworrior codeworrior requested a review from a team January 27, 2023 13:14
@codeworrior codeworrior merged commit cbf536b into main Jan 27, 2023
@codeworrior codeworrior deleted the align-jsdoc-with-openui5 branch January 27, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants