Fix Carthage warning when building by including in workspace #26
Conversation
When this project is built by including it in another workspace, instead of building by command line with `carthage`, using the FRAMWORK_SEARCH_PATH of `$(PROJECT_DIR)/Carthage/Build/iOS` can produce an error, since `$(PROJECT_DIR)/Carthage/Build/iOS` might not exist. To fix this we should use a submodule for our dependencies and include them in the RxKeyboard.xcworkspace. This will allow us to still compile the RxKeyboard library.
Wouldn't compile since we updated our RxSwift required version.
| - RxCocoa (>= 3.0) | ||
| - RxSwift (>= 3.0) | ||
| - RxSwift (3.1.0) | ||
| - RxCocoa (3.5.0): |
There was a problem hiding this comment.
Any reason to increase all the minimum versions in the Podfile.lock ?
There was a problem hiding this comment.
Yeah, I think Podfile.lock is an unrelated change.
There was a problem hiding this comment.
Because without it the example won't compile. If you just run pod install it says it can't meet the requirements of the 3.4.0 that the library requires, while being locked to 3.1.0.
There was a problem hiding this comment.
I have it as two commits. I can remove that commit if necessary. It does need updating though 😄.
There was a problem hiding this comment.
Uhm very weird it would require 3.4 , but even if so let's try keep it to the minimum required? 3.5 isn't a requirement here. So besides that I have no problems with this PR
There was a problem hiding this comment.
I just remembered that there was #20. I think it makes sense.
|
Thanks for your contribution! |
Fixes #25.
This updates the workspace to build with a submodule for RxSwift instead of assuming that the framework will be built to a specific location.
I also updated the Podfile.lock in the Example directory.
I tested this both building by the command line with
carthageand by including the project directly into a workspace.