Should not list Carthage in Framework Search Paths

[brentleyjones]

Currently FRAMEWORK_SEARCH_PATHS is set to $(PROJECT_DIR)/Carthage/Build/iOS. This gives a warning when building from source in a consuming workspace:

ld: warning: directory not found for option '-F/Users/bejones/Development/project/Carthage/Checkouts/RxKeyboard/Carthage/Build/iOS'

The correct setup is to not have this and to include RxSwift in the Workspace and use Xcode's Implicit Dependency Management. That way it knows how to compile both as a part of Carthage and in the workspace for development: https://www.quora.com/How-should-an-OSS-library-be-structured-for-distribution-with-both-Carthage-and-CocoaPods/answer/Justin-Spahr-Summers

[brentleyjones]

Do we agree that this should/can be fixed? It's our last warning in our codebase currently.

[devxoul]

Oh sorry, I totally forgot about it. 🙏 Could you please create a PR for this? I'm not experienced with Carthage.

[brentleyjones]

Sure, I'll try to get to it this week.

[freak4pc]

Uhm to be honest I wanted to fix this real quickly but I cannot reproduce your issue.

[brentleyjones]

@freak4pc You need to build the project by including it in the workspace, not buy using carthage on the command line. We use carthage to manage the dependencies, but not to build it.

[freak4pc]

Could you provide a dummy project? I'm not sure which workspace you're referring to in that case :)

[brentleyjones]

In the image you have, you have CarthageTest as a project in a (probably implicit) workspace. Next to it you would drag in the RxKeyboard project. By including it in the same workspace it will be built with Xcode's Implicit Dependency Management (see link in original comment).

To provide an example project I would probably spend the couple more minutes and fix it, so it would be on the same timeline, sometime this week. Carthage itself uses this format though (https://github.com/Carthage/Carthage/blob/master/Carthage.xcworkspace/contents.xcworkspacedata) so you can see how they setup their workspace for an example.

[freak4pc]

Ok, not sure if I'm doing anything special here but - I did reproduce your issue, when dragging the product framework from RxKeyboard to my own project in the same workspace, it showed that message, but then I noticed that "Framework Search Path" was configured on my own project and not on RxKeyboard. When removing that line, I'm not seeing that warning again.

Anyways if you're still experiencing it I'll leave it to you since I can't find an issue inside RxKeyboard itself :)